Skip to content

Implement token_get_all() TOKEN_AS_OBJECT mode #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Implement token_get_all() TOKEN_AS_OBJECT mode #2430

wants to merge 1 commit into from

Conversation

nikic
Copy link
Member

@nikic nikic commented Mar 23, 2017

New implementation of #1727.

Apart from the uniform interface (no more distinction between array and char tokens), the object representation performs better as well:

// Normal:
float(13.47053527832) // Memory usage
float(2.6691157817841) // Time x500 runs
// TOKEN_AS_OBJECT
float(7.4596405029297) // Memory usage
float(1.881500005722) // Time x500 runs

@nikic
Copy link
Member Author

nikic commented Mar 25, 2017 •
edited
Loading

Time quota exceeded.

@nikic nikic closed this Mar 25, 2017
@staabm
Copy link
Contributor

staabm commented Mar 25, 2017

Please noo.. this patch was awesome with only minor public facing api changes. Dont let others bring you down with all the overengineered nonesense.

@nikic nikic mentioned this pull request May 1, 2017
Closed
@nikic nikic mentioned this pull request Sep 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikic @staabm @krakjoe